chore: cleanup

vitest-dev · Mar 22, 2023 · 82e0f3a · 82e0f3a
1 parent 96af462
commit 82e0f3a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/packages/browser/src/client/main.ts b/packages/browser/src/client/main.ts
@@ -25,11 +25,6 @@ const browserHashMap = new Map<string, string>()
 const url = new URL(location.href)
 const testId = url.searchParams.get('id') || 'unknown'
 
-const importId = (id: string) => {
-  const name = `/@id/${id}`
-  return import(name)
-}
-
 const getQueryPaths = () => {
   return url.searchParams.getAll('path')
 }
@@ -124,8 +119,8 @@ async function runTests(paths: string[], config: any) {
       await startTests([file], runner)
   }
   finally {
-    await rpcDone()
     await stopCoverageInsideWorker(config.coverage, executor)
+    await rpcDone()
     await rpc().onDone(testId)
   }
 }
diff --git a/packages/browser/src/client/runner.ts b/packages/browser/src/client/runner.ts
@@ -32,7 +32,7 @@ export function createBrowserRunner(original: any, coverageModule: CoverageHandl
     async onAfterRunSuite() {
       await super.onAfterRunSuite?.()
       const coverage = await coverageModule?.takeCoverage?.()
-      await this.client.rpc.onAfterSuiteRun({ coverage })
+      await rpc().onAfterSuiteRun({ coverage })
     }
 
     onCollected(files: File[]): unknown {

diff --git a/test/browser/specs/runner.test.mjs b/test/browser/specs/runner.test.mjs
@@ -5,7 +5,7 @@ import { execa } from 'execa'
 
 const browser = process.env.BROWSER || 'chrome'
 
-const { stderr, stdout } = await execa('npx', ['vitest', `--browser=${browser}`, '--browser.headless'], {
+const { stderr, stdout } = await execa('npx', ['vitest', `--browser.name=${browser}`, '--browser.headless'], {
   env: {
     ...process.env,
     CI: 'true',