fix(vite-node): make resolveId optional

vitest-dev · Mar 16, 2022 · aba4ea8 · aba4ea8
1 parent a8955bb
commit aba4ea8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/vite-node/src/client.ts b/packages/vite-node/src/client.ts
@@ -55,7 +55,7 @@ export class ViteNodeRunner {
     const request = async(dep: string) => {
       // probably means it was passed as variable
       // and wasn't transformed by Vite
-      if (this.shouldResolveId(dep)) {
+      if (this.options.resolveId && this.shouldResolveId(dep)) {
         const resolvedDep = await this.options.resolveId(dep, id)
         dep = resolvedDep?.id?.replace(this.root, '') || dep
       }

diff --git a/packages/vite-node/src/types.ts b/packages/vite-node/src/types.ts
@@ -38,9 +38,9 @@ export interface ModuleCache {
 }
 
 export interface ViteNodeRunnerOptions {
-  fetchModule: FetchFunction
-  resolveId: ResolveIdFunction
   root: string
+  fetchModule: FetchFunction
+  resolveId?: ResolveIdFunction
   base?: string
   moduleCache?: Map<string, ModuleCache>
   interopDefault?: boolean