handle descriptors only containing a getter

vitest-dev · Mar 20, 2023 · c673476 · c673476
1 parent 0ad1acc
commit c673476
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/packages/utils/src/helpers.ts b/packages/utils/src/helpers.ts
@@ -88,7 +88,7 @@ export function clone<T>(val: T, seen: WeakMap<any, any>): T {
     const props = getOwnProperties(val)
     for (const k of props) {
       Object.defineProperty(out, k, {
-        ...Object.getOwnPropertyDescriptor(val, k),
+        enumerable: true,
         value: clone((val as any)[k], seen),
       })
     }

diff --git a/test/core/test/utils.spec.ts b/test/core/test/utils.spec.ts
@@ -152,9 +152,10 @@ describe('deepClone', () => {
 
   test('can clone classes with proxied enumerable getters', () => {
     const obj = Symbol.for('aClass')
+    interface TestShape { a: number; b: string }
     class A {
-      [obj]: { a: number; b: string }
-      constructor(data: { a: number; b: string }) {
+      [obj]: TestShape
+      constructor(data: TestShape) {
         this[obj] = data
         return new Proxy(this, {
           ownKeys() {
@@ -164,7 +165,6 @@ describe('deepClone', () => {
             return {
               ...Reflect.getOwnPropertyDescriptor(data, p),
               enumerable: true,
-              writable: false,
             }
           },
         })
@@ -178,7 +178,13 @@ describe('deepClone', () => {
         return this[obj].b
       }
     }
-    const aClass = new A({ a: 1, b: 'B' })
+    const shape = { a: 1 } as TestShape
+    Object.defineProperty(shape, 'b', {
+      configurable: true,
+      enumerable: true,
+      get: () => 'B',
+    })
+    const aClass = new A(shape)
     expect(aClass.a).toEqual(1)
     expect(aClass.b).toEqual('B')
     expect(Object.keys(aClass)).toEqual(['a', 'b'])