fix: correctly resolve buffer on typed arrays

vitest-dev · Aug 24, 2023 · fd1447c · fd1447c
1 parent 7dac059
commit fd1447c
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/packages/vitest/src/integrations/env/jsdom-keys.ts b/packages/vitest/src/integrations/env/jsdom-keys.ts
@@ -163,6 +163,16 @@ const LIVING_KEYS = [
   'Headers',
   'AbortController',
   'AbortSignal',
+
+  'Uint8Array',
+  'Uint16Array',
+  'Uint32Array',
+  'Uint8ClampedArray',
+  'Int8Array',
+  'Int16Array',
+  'Int32Array',
+  'Float32Array',
+  'Float64Array',
   'ArrayBuffer',
   'DOMRectReadOnly',
   'DOMRect',

diff --git a/test/core/test/dom.test.ts b/test/core/test/dom.test.ts
@@ -164,6 +164,25 @@ it('uses jsdom ArrayBuffer', async () => {
   expect(arraybuffer.constructor === ArrayBuffer).toBeTruthy()
 })
 
+it.each([
+  'Uint8Array',
+  'Uint16Array',
+  'Uint32Array',
+  'Uint8ClampedArray',
+  'Int16Array',
+  'Int32Array',
+  'Int8Array',
+  'Float32Array',
+  'Float64Array',
+] as const)('%s has buffer as ArrayBuffer', async (constructorName) => {
+  const Constructor = globalThis[constructorName]
+  const typedArray = new Constructor([1])
+  expect(typedArray.constructor.name).toBe(constructorName)
+  expect(typedArray instanceof Constructor).toBeTruthy()
+  expect(ArrayBuffer.isView(typedArray)).toBeTruthy()
+  expect(typedArray.buffer instanceof ArrayBuffer).toBeTruthy()
+})
+
 it('doesn\'t throw, if listening for error', () => {
   const spy = vi.fn((e: Event) => e.preventDefault())
   window.addEventListener('error', spy)