Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement msw sample react with testing lib #315

Merged
merged 8 commits into from
Dec 26, 2021
Merged

feat: implement msw sample react with testing lib #315

merged 8 commits into from
Dec 26, 2021

Conversation

tigerabrodi
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Dec 25, 2021 •
edited

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: 3f62f54

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61c827cfb472d300091957df

😎 Browse the preview: https://deploy-preview-315--vitest-dev.netlify.app

mitchelvanbever
mitchelvanbever suggested changes Dec 25, 2021
View reviewed changes
Copy link
Contributor

@mitchelvanbever mitchelvanbever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am in my phone right now, so can't test it locally but looks like a solid example to me.

Will check it locally tomorrow once these changes are looked at 😉

test/msw-testing-lib-react/package.json Outdated Show resolved Hide resolved
test/msw-testing-lib-react/src/utils/test-utils.tsx Outdated Show resolved Hide resolved
antfu
antfu reviewed Dec 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mitchelvanbever
Copy link
Contributor

Example doesn't run. Would be if the dev command would fire up the dev server without any issues :)

@tigerabrodi
Copy link
Contributor Author

Example doesn't run. Would be if the dev command would fire up the dev server without any issues :)

ohh 🔥

I was so focused on testing, good point, it gotta spin up the server and work.

mitchelvanbever
mitchelvanbever reviewed Dec 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@tigerabrodi
Copy link
Contributor Author

Right now it seems like the only thing left is to solve the error which occurs when running dev command, which is related to using node-fetch, considering it works when not using node-fetch within the App file.

@mitchelvanbever @Aslemammad @antfu

Screenshot from 2021-12-26 08-57-26
Screenshot from 2021-12-26 08-57-17

@mitchelvanbever
Copy link
Contributor

Looking good to me 💯

@patak-dev patak-dev merged commit 4322292 into vitest-dev:main Dec 26, 2021
@patak-dev
Copy link
Member

Awesome work! Thanks for the new test playground!

JakeGinnivan pushed a commit to JakeGinnivan/vitest that referenced this pull request Jan 8, 2022
@tigerabrodi @JakeGinnivan
feat: implement msw sample react with testing lib (vitest-dev#315)
a77c305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

@patak-dev patak-dev patak-dev approved these changes

@mitchelvanbever mitchelvanbever mitchelvanbever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tigerabrodi @mitchelvanbever @patak-dev @antfu