-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies are not inlined when using ssr.noExternal with globs #5911
Comments
Indeed, glob doesn't seem to be supported for Vite uses vitest/packages/vite-node/src/externalize.ts Lines 157 to 162 in f969fb0
I created a repro with simpler dependencies https://github.com/hi-ogawa/reproductions/tree/main/vitest-5911-deps-inline-glob |
Thanks @hi-ogawa. I can work on a PR to support this behavior if that's whats recommended |
vite-node processes |
Ok. What would be the recommended approach with globs? |
If I knew what to do with this, we would've already implemented it 😞 I don't know how to solve these, they were always resolved differently in Vite and Vitest. Vite can also resolve monorepo packages while Vitest expects that the package is in If it's fine to keep this difference, we can just apply the glob with the same rule - |
Thanks @sheremet-va. I think it's fine to keep this difference, and note that globs are not expected to be inlined also |
Describe the bug
The docs state that anything in the
ssr.noExternal
array in the Vite config is automatically added to thetest.server.deps.inline
array.Globs do not seem to be supported.
Repo: https://github.com/eduardoRoth/analog-ionic-capacitor-template
Reproduction
npm i
@ionic/angular
from thetest.server.deps.inline
array.@ionic/**
is already in thessr.noExternal
array.npx ng test
ssr.noExternal
array@ionic/angular
npx ng test
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: