Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage.exclude should be fully configurable #5965

Closed
6 tasks done
AriPerkkio opened this issue Jun 24, 2024 · 0 comments · Fixed by #5997
Closed
6 tasks done

coverage.exclude should be fully configurable #5965

AriPerkkio opened this issue Jun 24, 2024 · 0 comments · Fixed by #5997
Labels
feat: coverage Issues and PRs related to the coverage feature p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@AriPerkkio
Copy link
Member

Describe the bug

Following configuration should overwrite all default values of coverage.exclude. It should not exclude dist directory:

defineConfig({
  test: {
    // Only node_modules should be excluded, nothing else
    coverage: { exclude: ['**/node_modules/**'] },
  }
})

Actual: Hard coded default values are still applied. dist is excluded no matter what.

Reproduction

https://github.com/donmccurdy/2024-06-24_vitest_coverage_issue

System Info

Any

Used Package Manager

npm

Validations

@AriPerkkio AriPerkkio added pending triage feat: coverage Issues and PRs related to the coverage feature p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: coverage Issues and PRs related to the coverage feature p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant