Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testNamePattern matches against full name (fix #838) #839

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

patak-dev
Copy link
Member

See #838

@netlify
Copy link

netlify bot commented Feb 23, 2022

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: 7eae433

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6216093fb551a300087a3264

😎 Browse the preview: https://deploy-preview-839--vitest-dev.netlify.app

@patak-dev
Copy link
Member Author

Thanks for the issue @holtwick. @sheremet-va, I've marked this as a fix. It could count as a breaking change but I don't think people would be affected. What do you think?

@sheremet-va
Copy link
Member

Thanks for the issue @holtwick. @sheremet-va, I've marked this as a fix. It could count as a breaking change but I don't think people would be affected. What do you think?

I thought we already did this 👀
I think it counts as fix, since it is an expected behaviour.

@antfu antfu merged commit e753493 into main Feb 23, 2022
@antfu antfu deleted the fix/testNamePattern-fullName branch February 23, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants