fix: svelte wasn't included in code coverage by default #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was poking around the code and noticed a typo that probably means svelte code coverage is broken. I didn't validate if it is or not. I don't think we have integration test infrastructure to write coverage around if code coverage works for svelte.
|
鉁旓笍 Deploy Preview for vitest-dev ready! 馃敤 Explore the source changes: d70331c 馃攳 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6218a4325c94a60008f63b3f 馃槑 Browse the preview: https://deploy-preview-851--vitest-dev.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢馃徎 I was poking around this part of the codebase and noticed a typo. This probably means svelte code coverage is broken. I didn't double check if it is or not because I don't have an easy environment setup.