fix: correctly remove import query from url #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 3472ca6 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6219cb6e0e62cd0008879560 😎 Browse the preview: https://deploy-preview-854--vitest-dev.netlify.app |
patak-dev
reviewed
Feb 25, 2022
packages/vite-node/src/utils.ts
Outdated
| @@ -19,7 +19,7 @@ export function normalizeId(id: string, base?: string): string { | |||
| .replace(/^(node|file):/, '') | |||
| .replace(/^\/+/, '/') // remove duplicate leading slashes | |||
| .replace(/[?&]v=\w+/, '?') // remove ?v= query | |||
| .replace(/\?import/, '') // remove ?import query | |||
| .replace(/[?&]import/, '?') // remove ?import query | |||
There was a problem hiding this comment.
Maybe it would be better to replace ?import by ? and &import by &? I don't know if having two ? in the URL will end up confusing Vite 🤔
Suggested change
| .replace(/[?&]import/, '?') // remove ?import query | |
| .replace(/([&?])(import)/,'$1') // remove ?import query |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836