fix: render original source if mapped in node #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: e1fc35c 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/623609d4a1fcd500081b6631 😎 Browse the preview: https://deploy-preview-987--vitest-dev.netlify.app |
patak-dev
reviewed
Mar 19, 2022
packages/vitest/src/node/error.ts
Outdated
| @@ -32,7 +32,8 @@ export async function printError(error: unknown, ctx: Vitest) { | |||
| printErrorMessage(e, ctx.console) | |||
| await printStack(ctx, stacks, nearest, async(s, pos) => { | |||
| if (s === nearest && nearest) { | |||
| const sourceCode = await fs.readFile(nearest.file, 'utf-8') | |||
| const file = nearest.sourcePos && nearest.sourcePos.source && nearest.sourcePos.source !== '.' ? join(nearest.file, '../', nearest.sourcePos.source) : nearest.file | |||
There was a problem hiding this comment.
We can use ?. here, and I think it will be good to extract a fileFromSourcePosition(position) utility so it can be reused in printStack
Suggested change
| const file = nearest.sourcePos && nearest.sourcePos.source && nearest.sourcePos.source !== '.' ? join(nearest.file, '../', nearest.sourcePos.source) : nearest.file | |
| const file = nearest?.sourcePos?.source !== '.' ? join(nearest.file, '../', nearest.sourcePos.source) : nearest.file |
There was a problem hiding this comment.
Extracted as: fileFromParsedStack, any idea why some tests appear to be failing?
There was a problem hiding this comment.
Thanks! The errors look unrelated, it seems an issue with a test expectation.
patak-dev
approved these changes
Mar 19, 2022
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
Co-authored-by: Jan Morawietz <jan.morawietz@paessler.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the first phase of #832 when a stack trace is interpreted in case of errors in node if a source map is present it ensures the proper file is rendered in the test summary.
This PR doesn't address the full scope of the issue as it would be better (arguably?) to also show the test file names correspondent to the mapped source if present but I don't yet understand how that could be achieved because at the point test file names are rendered source maps are not yet parsed
After this PR the repro code produces:
While it still shows test files as before:
