refactor: internal coverage typings #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
commented
Jan 19, 2023
Comment on lines
-56
to
-59
| export type CoverageOptions = | ||
| | BaseCoverageOptions & { provider?: null | CoverageProviderModule } | ||
| | CoverageC8Options & { provider?: 'c8' } | ||
| | CoverageIstanbulOptions & { provider?: 'istanbul' } |
There was a problem hiding this comment.
Had to refactor this union type into a conditional type due to weird behaviour in TypeScript. Link to TS Playground
It seems that Typescript thinks a string may also extend the interface CoverageProviderModule.
type NarrowedProvider = "istanbul" | ({ method: () => string; } & "istanbul")
sheremet-va
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8for a while so let's merge this separately.Fixes multiple internal typing violations of coverage typings. Reduces the amount of
astype assertions used to tricktsc. Typings are now actually correct and respond the runtime values.test/coverage-test/test/configuration-options.test-d.tsis passing