-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: ui copying to be part of browser's vite build #3137
build: ui copying to be part of browser's vite build #3137
Conversation
3c843d6
to
45369be
Compare
While we are here, I noticed some dependencies in the browser should be moved to "dev". From |
Let's include it in this PR. I'll go through browser package's dependencies and check how they are used. |
@sheremet-va if browser package runs before ui package the browser |
Please, read the previous conversation: #3137 (comment)
|
There is also a check for this in browser package's build. This will trigger if vitest/packages/browser/src/client/vite.config.ts Lines 23 to 28 in b9d6b7e
|
When using browser feature in local development with
pnpm dev
, the browser package'spnpm copy
is not run at all. UI in browser is a blank white page aspackages/ui
has not been copied there.This PR adds ui copying to be part of
pnpm dev
workflow. It also makes sure monorepo'spnpm build
command runspackages/browser
as last step to make surepackages/ui
has been completely built before copying it.Tested manually using locally linked package +
test/browser
.