Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "fix(vite-node): circular import stuck" #3418 #3479

Merged
merged 3 commits into from May 31, 2023
Merged

revert: "fix(vite-node): circular import stuck" #3418 #3479

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c064ff9
fix(vite-node): check circular before adding path to importers
sheremet-va May 31, 2023
96dac13
revert: "fix(vite-node): circular import stuck" #3418
sheremet-va May 31, 2023
799caa7
revert: circular test
sheremet-va May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite-node/src/client.ts
View file
Open in desktop
Expand Up @@ -194,7 +194,7 @@ export class ViteNodeRunner {
const getStack = () => `stack:\n${[...callstack, fsPath].reverse().map(p => ` - ${p}`).join('\n')}`

// check circular dependency
if (callstack.includes(fsPath) || callstack.some(c => this.moduleCache.get(c).importers?.has(fsPath)) || mod.importers.has(importee)) {
if (callstack.includes(fsPath) || callstack.some(c => this.moduleCache.get(c).importers?.has(fsPath))) {
if (mod.exports)
return mod.exports
}
Expand Down