feat(vitest): add "strict" option to node environment #3995
+433
−126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Vitest "just works" when testing native Node.js applications even when the regular application would fail due to ESM incompatibilities. It is a good idea to run tests in the same environment where the actual application is running, but there are some pitfalls when providing such an environment.
This PR aims to cover all possible ESM/CJS issues that might arise when running code in Node.js env. For the first iteration, we assume that the code is bundled as ESM (even if tsconfig says otherwise).
Closes #2841
Closes #2198
TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.