Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vitest): add "strict" option to node environment #3995

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sheremet-va
Copy link
Member

Description

Currently Vitest "just works" when testing native Node.js applications even when the regular application would fail due to ESM incompatibilities. It is a good idea to run tests in the same environment where the actual application is running, but there are some pitfalls when providing such an environment.

This PR aims to cover all possible ESM/CJS issues that might arise when running code in Node.js env. For the first iteration, we assume that the code is bundled as ESM (even if tsconfig says otherwise).

Closes #2841
Closes #2198

TODO:

  • Tests
  • Docs
  • Examples
  • Better error messages

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Aug 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 5f2cb16
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/64ec5353880f420008b1bbed
😎 Deploy Preview https://deploy-preview-3995--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va changed the title feat(vitest): feat: add "strict" option to node environment feat(vitest): add "strict" option to node environment Aug 21, 2023
@sheremet-va sheremet-va marked this pull request as draft August 22, 2023 12:53
@douglasg14b
Copy link

What happened to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitest incorrectly injects __dirname when type is module Option to turn off strict mode
2 participants