Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expect): support expect.closeTo api #4260

Merged
merged 5 commits into from Oct 7, 2023

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 6, 2023

Description

Thank @bartoszgolebiowski for the great work. This PR is based on #2827. I just added documentation and updated the test cases.

close: #2809
close: #2827

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 4f765b0
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/651fe4e67aa57e0008218164
😎 Deploy Preview https://deploy-preview-4260--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 7f91c6f into vitest-dev:main Oct 7, 2023
15 of 17 checks passed
@ghiscoding ghiscoding mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest compatibility API: expect.closeTo() is not supported
2 participants