Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove EnhancedSpy type, deprecate SpyInstance, improve mocks and vi documentation #4400

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

sheremet-va
Copy link
Member

Description

This PR

  • removes EnhancedSpy because it is an implementation detail and is no longer needed
  • deprecates SpyInstance in favor of MockInstance
  • adds inline documentation to "vi" object
  • adds inline documentation to mock instance
  • adds more documentation in general
  • updates vitepress to the latest version which changes design a little bit

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Oct 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit e848d55
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6540dcc2db821f0008c02938
😎 Deploy Preview https://deploy-preview-4400--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/vitest/src/integrations/vi.ts Outdated Show resolved Hide resolved
packages/vitest/src/integrations/vi.ts Outdated Show resolved Hide resolved
packages/vitest/src/integrations/vi.ts Outdated Show resolved Hide resolved
packages/vitest/src/integrations/vi.ts Outdated Show resolved Hide resolved
packages/vitest/src/integrations/vi.ts Show resolved Hide resolved
docs/api/vi.md Outdated Show resolved Hide resolved
docs/api/vi.md Outdated Show resolved Hide resolved
docs/api/vi.md Outdated Show resolved Hide resolved
docs/api/vi.md Outdated Show resolved Hide resolved
docs/api/mock.md Outdated Show resolved Hide resolved
sheremet-va and others added 2 commits October 31, 2023 11:48
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
@sheremet-va sheremet-va merged commit d40b3a5 into vitest-dev:main Oct 31, 2023
14 of 16 checks passed
@sheremet-va sheremet-va deleted the docs/improve-some-docs branch October 31, 2023 11:20
@userquin userquin mentioned this pull request Oct 31, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants