Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't expand snapshot diff by default #4430

Merged

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 2, 2023

Description

Currently very long snapshots take a lot of space to display their diff even if there is only one change. This PR makes it so snapshots only show a small patch that actually changed. To allow restoring previous behaviour, the --expand-snapshot-diff flag is introduced.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

stackblitz bot commented Nov 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 853e2bd
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6546466892fb7f0008220ec6

@sheremet-va sheremet-va marked this pull request as ready for review November 4, 2023 13:26
@sheremet-va sheremet-va merged commit 8983cd4 into vitest-dev:main Nov 6, 2023
14 of 16 checks passed
@sheremet-va sheremet-va deleted the fix/dont-expand-snapshot-by-default branch November 6, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant