Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix --watch.include option of dev scripts #4702

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 8, 2023

Description

While experimenting with browser package code, I noticed that pnpm dev is not picking up the change of some files.

I assumed --watch.include hasn't been updated after getting more files there, so I updated the options to align with other places such as:

"dev": "rollup -c --watch --watch.include 'src/**'",

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 4865a0e
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6572e0d33f0b620008d34687

@hi-ogawa hi-ogawa changed the title chore(browser): fix 'dev:node' script chore(browser): fix dev:node script Dec 8, 2023
@hi-ogawa hi-ogawa changed the title chore(browser): fix dev:node script chore: fix dev scripts of browser and ui packages Dec 8, 2023
@hi-ogawa hi-ogawa changed the title chore: fix dev scripts of browser and ui packages chore: fix --watch.include options of dev scriptx Dec 8, 2023
@hi-ogawa hi-ogawa changed the title chore: fix --watch.include options of dev scriptx chore: fix --watch.include option of dev scripts Dec 8, 2023
@hi-ogawa hi-ogawa marked this pull request as ready for review December 8, 2023 09:30
@AriPerkkio
Copy link
Member

Similar changes were done to other packages as well earlier last year: #2424

@AriPerkkio AriPerkkio merged commit 4fb7482 into vitest-dev:main Dec 8, 2023
16 checks passed
LorenzoBloedow pushed a commit to LorenzoBloedow/vitest that referenced this pull request Dec 19, 2023
@hi-ogawa hi-ogawa deleted the chore-browser-dev-node-watch branch December 19, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants