Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expect.poll utility #5708

Merged
merged 20 commits into from
May 14, 2024
Merged

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented May 11, 2024

Description

When rewriting UI tests, I found that we don't have an assertion resistant to flaky values. This should make it easier to check if a flaky condition is working correctly. I also expect to have this functionality built-in in future browser-only assertions.

TODO:

  • Docs
  • Tests

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from

await vi.waitFor(() => {
  expect(..).toBe(...)
});

@sheremet-va
Copy link
Member Author

sheremet-va commented May 11, 2024

How is this different from

await vi.waitFor(() => {
  expect(..).toBe(...)
});

It's more compact and easier to understand the idea behind it. Having several vi.waitFor just doesn't look as clean:

await createElement()

await vi.waitFor(() => {
  expect(getElement()).toBeInTheDocument()
})

await clickOnElement()

await vi.waitFor(() => {
  expect(getResult()).toEqual({ pass: true })
})
await createElement()

await expect.poll(() => getElement()).toBeInTheDocument()

await clickOnElement()

await expect.poll(() => getResult()).toEqual({ pass: true })

Playwright also has await expect(() => {}).toPass() API which looks more like vi.waitFor

@sheremet-va sheremet-va merged commit e2e0ff4 into vitest-dev:main May 14, 2024
15 of 16 checks passed
@sheremet-va sheremet-va deleted the feat/expect-poll branch May 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants