Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): load module graph on tab selection #5844

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Jun 4, 2024

Description

This PR includes:

  • load module graph only when the graph tab is selected and when the current module changes
  • show file name relative to the root config in FileDetails.vue header (rigth now, relativeToRoot function using config.root where config is a vue ref, and so the full path is shown)
  • added some icons to the tabs: since we've moved the details from the mid panel, we've some extra space (check screenshot below)
  • normalize all composable imports using ~ instead relative paths: I'll check next weekend to configure autoimport properly, we should remove all composable imports from vue files
  • WIP: change module entry dialog header to include the project and the relative path: in the current version showing only the full path (check screenshot below)
  • added watcher to select report tab in details pane when selected file change
  • WIP: I'll try to remove previous watcher and reload the graph when the active file changes and the current tab is the graph
  • WIP: switch navigation behavior, right now selecting the task expands the nested tests/tasks and clicking on the details button opens the file details; the new behaviour will open the file details when clicking on the task and will expand the nested tests/tasks when clicking the details button

New icon tabs

imagen

Module graph entry detail

imagen

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@userquin userquin marked this pull request as draft June 4, 2024 22:59
@userquin userquin changed the title feat(ui): load module graph on demand feat(ui): load module graph on tab selection Jun 4, 2024
@sheremet-va
Copy link
Member

the new behaviour will open the file details when clicking on the task and will expand the nested tests/tasks when clicking the details button

This doesn't make any sense though? The current behaviour is correct and follows the same idea that we have in vscode extension

@userquin userquin marked this pull request as ready for review June 6, 2024 13:34
@userquin userquin requested a review from sheremet-va June 6, 2024 13:34
@sheremet-va
Copy link
Member

LGTM 👍🏻

@sheremet-va sheremet-va merged commit b117e87 into main Jun 6, 2024
16 checks passed
@sheremet-va sheremet-va deleted the userquin/feat-load-graph-on-demand branch June 6, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants