fix: make error more informative

vitest-dev · Mar 22, 2022 · 5ced470 · 5ced470
1 parent ae7cc44
commit 5ced470
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 20 deletions.
diff --git a/samples/basic/test/mul.test.ts b/samples/basic/test/mul.test.ts
@@ -2,4 +2,5 @@ import { expect, describe, it } from "vitest";
 
 describe("mul", () => {
   it.skip("run", () => {});
+  it("run", () => {});
 });
diff --git a/src/pure/runner.ts b/src/pure/runner.ts
@@ -67,7 +67,7 @@ export class TestRunner {
   });
   constructor(
     private workspacePath: string,
-    private vitePath: string | undefined
+    private vitestPath: string | undefined
   ) {}
 
   async scheduleRun(
@@ -91,10 +91,12 @@ export class TestRunner {
         args.push("-t", testNamePattern);
       }
 
+      let child;
+      let error: any;
       try {
-        let child;
-        if (this.vitePath) {
-          child = spawn(this.vitePath, args, {
+        // it will throw when test failed or the testing is failed to run
+        if (this.vitestPath) {
+          child = spawn(this.vitestPath, args, {
             cwd: this.workspacePath,
             stdio: ["ignore", "pipe", "pipe"],
           });
@@ -109,24 +111,14 @@ export class TestRunner {
           log(line + "\r\n");
         }
       } catch (e) {
-        console.error(e);
+        error = e;
       }
 
       if (!existsSync(path)) {
-        return {
-          numFailedTests: 0,
-          numFailedTestSuites: 0,
-          numPassedTests: 0,
-          numPassedTestSuites: 0,
-          numPendingTests: 0,
-          numTodoTests: 0,
-          numPendingTestSuites: 0,
-          numTotalTests: 0,
-          numTotalTestSuites: 0,
-          startTime: 0,
-          success: false,
-          testResults: [],
-        };
+        console.error("scheduleRun error", error.toString());
+        console.error(error.stack);
+        console.log("vitestPah", this.vitestPath, args, this.workspacePath);
+        throw error;
       }
 
       const file = await readFile(path, "utf-8");

diff --git a/src/runHandler.ts b/src/runHandler.ts
@@ -211,7 +211,7 @@ async function runTest(
         run.errored(
           testCase,
           new vscode.TestMessage(
-            "Testing is not started correctly. Please check your configuration."
+            "Unexpected condition. Please report the bug to https://github.com/zxch3n/vitest-explorer/issues"
           )
         );
       });