Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add TestData tests #273

Merged
merged 2 commits into from
Mar 4, 2024
Merged

test: add TestData tests #273

merged 2 commits into from
Mar 4, 2024

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Feb 29, 2024

  • Added small e2e tests for TestFile and more.
  • Moved fixture data for parse tests to files.
  • Applied eslint rules to files in test/

hi-ogawa
hi-ogawa approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Being able to write a test with vscode.tests.createTestController is great!

@sheremet-va sheremet-va merged commit c8ed24b into vitest-dev:main Mar 4, 2024
1 check passed
@hi-ogawa hi-ogawa mentioned this pull request Mar 5, 2024
Merged
uioporqwerty pushed a commit to uioporqwerty/vitest-vscode-issue-136 that referenced this pull request Mar 5, 2024
@keroxp @uioporqwerty
test: add TestData tests (vitest-dev#273)
9aae3ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keroxp @hi-ogawa @sheremet-va