Fix errors when workspace path has spaces on Windows #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbei
force-pushed
the
main
branch
2 times, most recently
from
8262ac9
to
1a5b443
Compare
Also removes quote typo in error log
|
This is fixed with #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add quotes to command and args when path contains spaces. Fixes #200 on Windows.
Current status
Running tests directly from play (▶) button: Works well
Running "Debug Test": Seems to work now
Debug mode will add quotes again despite seemly using the same code as running tests directly.Arguments become ""double quotes""
Starting watch/continuous mode:
On the "samples/basic" test folder, fails with
Error: No test suite found in file, similar errors as "No test suite found in file" Once again vitest#3296Also has colour formatting errors in vscode output (use workaround
--no-color）On another personal repo, fails with
Error: Cannot read properties of undefined (reading 'test')similar to windows drive casing causes - TypeError: Cannot read properties of undefined (reading 'test') vitest#5251Any guidance would be appreciated.
Minor: removes quote typo in error log.