Clean up trait implementations. #33
Conversation
Now every struct has the complete set of AsRef, Borrow and From impls to get at the things inside it. There are also From impls for constructing structs where that is infallible. Into impls have been removed, since the standard library has a blanket impl for everything that implements From.
|
Hey, sorry I haven't gotten back to you on this yet. I started to look at it and it looks good, but haven't completed review. |
|
If it really is just a "clean up", i.e. does not break any API, feel free to merge though. |
|
I'm... pretty sure it's just a cleanup, but implementing a trait is considered a semver-minor change, so it'll be good to have another pair of eyes over it. |
| impl Into<PathArc> for PathAbs { | ||
| fn into(self) -> PathArc { | ||
| self.0 | ||
| impl From<PathAbs> for PathArc { |
There was a problem hiding this comment.
This is good, as "From<T> for U implies Into<U>for T"
| @@ -460,49 +460,30 @@ impl Deref for PathDir { | |||
| } | |||
| } | |||
|
|
|||
| impl Into<PathAbs> for PathDir { | |||
| /// Downgrades the `PathDir` into a `PathAbs` | |||
There was a problem hiding this comment.
Do we want to keep the docs? Probably not...
There was a problem hiding this comment.
I considered it, but all these traits have pretty solid, unambiguous definitions, and have their own documentation which we don't really need to duplicate. The more docs we have, the more docs we need to maintain, so we should concentrate on the structs and functions that are unique to this crate instead of things from the standard library.
|
I did a quick skim and checked to make sure it makes sense to implement these. Let me know if/when you want to do a release. |
|
I've still got my "replace PathArc with traits" change queued up; maybe you want to wait for that before doing a release, maybe you'd rather do one last release before it lands so people can make use of these changes without having to tackle all of them. |
Now every struct has the complete set of AsRef, Borrow and From impls to get at the things inside it. There are also From impls for constructing structs where that is infallible.
Into impls have been removed, since the standard library has a blanket impl for everything that implements From.