New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes examples folder #47
Conversation
5978a9c
to
f35066f
Compare
f35066f
to
b09351d
Compare
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 84.61% 83.13% -1.49%
==========================================
Files 4 3 -1
Lines 91 83 -8
Branches 16 14 -2
==========================================
- Hits 77 69 -8
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
I get
Installing the package fixes it and I can finally see the examples project! 🎉 Worth adding this build to CI as part of this PR? |
examples/src/Form.tsx
Outdated
/> | ||
</CardContent> | ||
<CardActions> | ||
<Button fullWidth={true} type="submit" color="primary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on a disabled attribute?
disabled={!isValid}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, let's add it in
bce846d
to
6fd4e31
Compare
6fd4e31
to
309031e
Compare
|
What's this PR do?
Where should the reviewer start?
/examples folder and validators.ts
How should this be manually tested?
npm start
in examples folderWhat are the relevant tickets / issues?
#34 #37