Rounding error #19
Merged
Rounding error #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'rounding' now should round correctly. Before it was effectively doing a floor() operation. Fixes vitoc#7
|
fyi a user was complaining that the equivalent change in Imagick broken something - https://bugs.php.net/bug.php?id=71283 I've asked them to provide more info as I can't reproduce - but I suggest holding of on tagging the next release until the issue is resolved. |
|
Looks like this the similar Imagick issue had been resolved. |
|
And more importantly, no one has complained yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ought to be checked. I've copied and pasted it from Imagick, but it needs a second set of eyes on it.
Basically it 'fixes' the rounding to be what most people would expect, and should match the behaviour of CLI GraphicsMagick. Fixes #7
I put the legacy flag in there so that people who rely on the current behaviour don't get too upset. TBH, they should probably just resize the image directly themselves.