Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean duplicate constant definition, fix #40 #41

Merged
merged 1 commit into from
Jun 25, 2016

Conversation

remicollet
Copy link
Contributor

No description provided.

@vitoc vitoc merged commit 96b6658 into vitoc:master Jun 25, 2016
@vitoc
Copy link
Owner

vitoc commented Jun 25, 2016

Thanks @remicollet !

@remicollet
Copy link
Contributor Author

@vitoc checking the reflection change between 2.0.2RC2 and 2.0.3RC1, I notice a minor problem with my PR.

It drops the duplicated constants, but in fact one was define twice, but differently

GMAGICK_REGISTER_CONST_LONG("INTERLACE_NONE", NoInterlace); //Don't interlace image (RGBRGBRGBRGBRGBRGB...)
GMAGICK_REGISTER_CONST_LONG("INTERLACE_NO", NoInterlace);

I have remove the _NO, but it is probably better to keep it and remove _NONE instead (as _NO was used in previous version for PHP 5)

Sorry for not noticing this before

@remicollet
Copy link
Contributor Author

@pinepain @vitoc see pr #42

@vitoc
Copy link
Owner

vitoc commented Jun 26, 2016

Thanks guys, fixed in release 2.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants