Polls #321
Merged
Polls #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pollButton; supress missing translations errors when debugging
remove imageUpload from pollView,
add buttons for add/delete options, format poll text fields, change poll option placeholder string rename primaryPollDescription string
add PollOption, PollVoteValueRange component previews, rename poll_recipients string
change value range placeholder strings
rename poll strings/values
add/delete poll options functionality, don't allow deleting first 2 poll options
move recipients field to optional section, make recipients, options textFields fillMaxWidth
add user's pubkey to recipients field, add poll field saveable texts to pollViewModel,
add clearState fun to pollViewModel, add refined PollNoteEvent to Event,
disable sendPoll button unless all fields valid
remove always true condition from Account.isAcceptable()
prefix all poll composables with 'New', move all poll composables to actions folder, move jsonToPollOptions parser to PollNoteEvent
add PollNoteEvent.kind to DataSources, add consume(PollNoteEvent) to LocalCache,
simplify code for displaying PollNoteEvents with replyTos or mentions, fix pollOptions (and other poll fields) get from tags functions
simplify PollNote() arguments, use parent's backgroundColor, breakout PollNote modifier
fix PollNoteEvent field getter return types
add poll_option tag and handlers to LnZapEvents and zap funs,
show vote option tallies, format zapped vote button icons
option zap widgets layout improvements
fix PollNoteEvent tag getter funs for the final fucking time (hopefully)!, only show option amounts if user has zapped poll note, make poll options wider
create new PollNoteViewModel for each PollNote, fix isVoteAmountAtomic to directly launch wallet
add padding to option text
fix buggy click event on disabled zap button
increase bolt size of poll icon
Semisol
reviewed
Mar 29, 2023
app/src/main/java/com/vitorpamplona/amethyst/service/model/LnZapEvent.kt
Outdated
Show resolved
Hide resolved
fix translatable typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toadlyBroodle/amethyst polls branch merged into main