Skip to content

Commit

Permalink
Remove unnecessary soft linking of Data Detector framework
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=258469
rdar://111222985

Reviewed by Chris Dumez.

This soft linking is no longer needed, since the WebContent process is no longer being terminated when accessing launchd.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::softlinkDataDetectorsFrameworks): Deleted.

Canonical link: https://commits.webkit.org/265473@main
  • Loading branch information
pvollan committed Jun 23, 2023
1 parent b2c434a commit 9a99108
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Expand Up @@ -268,16 +268,6 @@ static Boolean isAXAuthenticatedCallback(audit_token_t auditToken)
}
#endif

static void softlinkDataDetectorsFrameworks()
{
#if ENABLE(DATA_DETECTION)
PAL::isDataDetectorsCoreFrameworkAvailable();
#if PLATFORM(IOS_FAMILY)
PAL::isDataDetectorsUIFrameworkAvailable();
#endif // PLATFORM(IOS_FAMILY)
#endif // ENABLE(DATA_DETECTION)
}

enum class VideoDecoderBehavior : uint8_t {
AvoidHardware = 1 << 0,
AvoidIOSurface = 1 << 1,
Expand Down Expand Up @@ -537,10 +527,6 @@ static void setVideoDecoderBehaviors(OptionSet<VideoDecoderBehavior> videoDecode

disableURLSchemeCheckInDataDetectors();

// Soft link frameworks related to Data Detection before we disconnect from launchd because these frameworks connect to
// launchd temporarily at link time to register XPC services. See rdar://93598951 (my feature request to stop doing that)
softlinkDataDetectorsFrameworks();

#if HAVE(VIDEO_RESTRICTED_DECODING) && PLATFORM(MAC)
if (codeCheckSemaphore)
dispatch_semaphore_wait(codeCheckSemaphore.get(), DISPATCH_TIME_FOREVER);
Expand Down

0 comments on commit 9a99108

Please sign in to comment.