Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valet Share does not copy or show the latest ngrok url, but only the first one #7

Open
lancepioch opened this issue Sep 10, 2016 · 2 comments

Comments

@lancepioch
Copy link

If you use it more than once, it'll open up multiple ngrok instances (which is fine), but it will keep displaying and copying to the clipboard only the first one.

@vitr
Copy link
Collaborator

vitr commented Sep 11, 2016

well, at least, both tunnels are working, just tested.
I believe, the problem is in the original valet code
public $tunnelsEndpoint = 'http://127.0.0.1:4040/api/tunnels';
the tunnel endpoint is hardcoded and ngrok creates the second on port 4041, and next on 4042, etc.
So, we need to keep track of running ngrok instances and picking the right one.
I have to test on Mac, but I guess, there might be the same issue.

@vitr
Copy link
Collaborator

vitr commented Sep 14, 2016

the issue has been confirmed and reproduced with original valet on Mac.
I created an issue here laravel/valet#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants