Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record element modification by Reactions for TUID update #55

Closed
HeikoKlare opened this issue May 10, 2017 · 2 comments · Fixed by #428
Closed

Record element modification by Reactions for TUID update #55

HeikoKlare opened this issue May 10, 2017 · 2 comments · Fixed by #428

Comments

@HeikoKlare
Copy link
Contributor

Reactions perform modifications on target models that are not reflected in any way. They are not used for transitively propagating them by triggering further Reactions and are also not investigated for TUID updates.

TUID updates for elements modified by Reactions are currently performed by the Reactions code that triggers the update procedure for certain elements at the correct points of time. This has the drawback that modifications on the Reactions language have to be performed correctly so that the TUID update is still performed correctly. This is error-prone and elaborate.
We should record changes in the models of the VSUM during change propagation through Reactions and perform just-in-time TUID updates just like during modifications by the user. This will potentially require us to perform resource changes just-in-time as the change recorder has to be started for newly created models.

@HeikoKlare
Copy link
Contributor Author

This is not that easy:
From now, we record changes performed by Reactions in other models. Nevertheless, TUID updates are performed when converting the recorded changes into VitruviusChanges. This is too late, because Reactions require a just-in-time update of TUIDs. This would require to applyAndReverse each changeDescription in the moment it occurs. This, however, does not work but produces errors.

@HeikoKlare
Copy link
Contributor Author

This issue may be easier to solve after solving #156. If correspondences use UUIDs instead of TUIDs, TUIDs may not be necessary during Reaction execution anymore. But we really have to think about that in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant