Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUID resolution ignores reference name #61

Closed
HeikoKlare opened this issue May 15, 2017 · 0 comments · Fixed by #428
Closed

TUID resolution ignores reference name #61

HeikoKlare opened this issue May 15, 2017 · 0 comments · Fixed by #428
Labels

Comments

@HeikoKlare
Copy link
Contributor

Some time ago, we added the reference name to the TUID to make the TUID more unambiguous and improve resolution.
While the TUID calculator adds the reference name to the TUID (at least in cases in which the attribute is set), the resolver does not use the reference name for restricting the lookup. In fact, it ignores it and thus potentially procudes false results.

We have to update the TUID resolver to use the reference name for retrieving the matching element. Besides, this also improves resolution performance. Furthermore, we have to update the TUID calculation to also add the reference name when the attribute is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant