This repository has been archived by the owner on Nov 26, 2023. It is now read-only.
Reset counters only in existing class def scopes #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When PyCG processes a new class definition, it tries to reset the counters of the scope within the namespace of the correspondoing class. In some cases, were a scope object has not been instantiated for a given namespace, the
reset_counters()
method is called upon a NoneType Object resulting in an AttributeError which breaks PyCG.We adopted the visit_ClassDef method to reset the counter of a corresponding namespace scope only when the specific scope exists.
Steps to Test
Before this PR, having downloaded and unziped the neuromation:20.12.7 pypi library, when running the
pycg --package neuromation $(find neuromation -type f -name "*.py") --fasten
we used to get the following error