Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project.json should be dumped with a trailing newline #93

Closed
phorward opened this issue Jan 9, 2024 · 0 comments · Fixed by #102
Closed

project.json should be dumped with a trailing newline #93

phorward opened this issue Jan 9, 2024 · 0 comments · Fixed by #102
Labels
bug Something isn't working
Milestone

Comments

@phorward
Copy link
Member

phorward commented Jan 9, 2024

Occasionally, when editing settings in project.json, this happens:

--- a/project.json
+++ b/project.json
@@ -34,4 +34,4 @@
         "application_name": "myapp-viur3",
         "version": "$(year)-$(month)-$(day)-$(user)"
     }
-}
\ No newline at end of file
+}

A solution for this would be to simply append an \n each time the file is being stored by viur-cli.

@phorward phorward added the bug Something isn't working label Jan 9, 2024
@Grashalmbeisser Grashalmbeisser added this to the V2.0.0 milestone Jan 19, 2024
@Grashalmbeisser Grashalmbeisser linked a pull request Jan 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants