Improve Code Health Infrastructure: Lint, Coverage, and Type Checking #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that ignoring __init__.py didn't work.
U8NWXD
changed the title
|
@eagmon this PR is ready to go! Could you take a look? |
eagmon
reviewed
Jan 6, 2021
eagmon
reviewed
Jan 6, 2021
1fish2
reviewed
Jan 6, 2021
| @@ -41,4 +41,5 @@ | |||
| 'pymongo', | |||
| 'pytest', | |||
| 'scipy', | |||
| 'pylint', | |||
There was a problem hiding this comment.
Can we remove 'pytest' and 'pylint' here, being dev tools not needed by clients of this library?
| python-dateutil==2.8.1 | ||
| scipy==1.5.4 | ||
| six==1.15.0 |
There was a problem hiding this comment.
Is the six package just an indirect dependency or is it no longer needed now that we've dropped Python 2 (RIP)?
Idea: To aid future maintenance, we could group requirements.txt into sections containing
- the direct dependencies -- anything in this group can be pruned out from here and setup.py if/when the code no longer
importsit, like kafka - the dev tools -- not imported; not needed in setup.py; used in dev scripts
- the frozen indirect dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #42 for how to use the features introduced here