Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a pretty serious oversight that I discovered when migrating wcecoli. If a process has multiple ports that share a variable name, and those ports are plugged into the same store through a composite, then the process could be updating the variable multiple times in a single update. Previously,
inverse_topology
in experiment useddeep_merge
, which would merge those updates, arbitrarily overwriting one with the other. We needed the option for both updates to be applied.To fix this,
inverse_topology
now uses a function calleddeep_merge_multi_update
. This is likedeep_merge
, but if a value is already present under a given key, it gets added to a list under the special key'_multi_update'
. Theapply_update
method looks for this special key, and will apply all updates under it to the same store.