Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add back button #183

Merged
merged 3 commits into from
Aug 27, 2021
Merged

feat: ✨ add back button #183

merged 3 commits into from
Aug 27, 2021

Conversation

toddlerer
Copy link
Contributor

@toddlerer toddlerer commented Aug 19, 2021

Thanks for developing this great extension.
I implemented a back button because I sometimes wanted to change the previous input value while answering a question.
Retain previous question values and values in middle of inputs, as shown in the gif below.

conventional-commits

In the case of QuickPick, it is possible that selectedItems would be preferable to value as a default when we are back, but I haven't done so because it would require major code changes to do so.

@yi-Xu-0100
Copy link
Collaborator

👋 Hi @toddlerer, Thanks for your contribution! This is a great feature for this extension, I will review it as soon as possible! 😁

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Aug 20, 2021
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-45415c8.vsix in artifacts. 🚀

@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Aug 20, 2021
@toddlerer
Copy link
Contributor Author

toddlerer commented Aug 20, 2021

Fixed bug that lineBreak disappeared. 6fd75b8
To do so, I made sure to do the format after all the questions were done.

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Aug 21, 2021
@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Aug 21, 2021
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-76c09c7.vsix in artifacts. 🚀

@yi-Xu-0100
Copy link
Collaborator

@vivaxy I have no other question about this feature. I test in windows and it performed well. 😁

If there is no more question about it, after the question about QuickPick being solved, I will merge it and release on next Friday. 😀

@toddlerer
Copy link
Contributor Author

Hi @yi-Xu-0100 @vivaxy,
I made the previous selection the default item when you do the Back action for QuickPick. 030bb4a

conventional-commits2

In case of (Normal) QuickPick (type, gitmoji)
Make the previously selected item active when you return.
The last value you entered is not retained.

In case of ConfigurableQuickPick (scope)
Make the previously selected item active when you return, except in the case of newItem.
In the case of newItemWithoutSetting, the previously entered value is retained when you return. In the case of newItemWithoutSetting, the previously entered value will be used as the default value when you return.
If newItem or newItemWithoutSetting is selected while there is a value being entered, the default value of the InputBox will be that value.
When returning from the InputBox state of newItem or newItemWithoutSetting, it returns to the type selection. (This may be a room for improvement.)

In case of InputBox (subject, body, footer)
The value you entered previously will be the default value when you return, unchanged from when I created this pull request.

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Aug 25, 2021
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-0633ab2.vsix in artifacts. 🚀

@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Aug 25, 2021
@yi-Xu-0100
Copy link
Collaborator

@toddlerer Thank you for your contribution. From the code, after a brief review, there are no more problems. In terms of the experimental function, I also tested it and felt that the effect was very good. 😁

@vivaxy If there are no other comments, I will post an update this Friday. 🧐

@yi-Xu-0100 yi-Xu-0100 merged commit f5d17fb into vivaxy:master Aug 27, 2021
@vivaxy
Copy link
Owner

vivaxy commented Aug 28, 2021

@toddlerer @yi-Xu-0100 Thank you all for the nice back button feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants