Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Gitmojis not searchable by name when format is set to Emoji #240

Closed
Jak-Ch-ll opened this issue Apr 21, 2022 · 4 comments · Fixed by #241 or #217
Closed

[BUG] Gitmojis not searchable by name when format is set to Emoji #240

Jak-Ch-ll opened this issue Apr 21, 2022 · 4 comments · Fixed by #241 or #217
Labels
bug Something isn't working enhancement New feature or request

Comments

@Jak-Ch-ll
Copy link

Describe the bug

The Gitmojis are not searchable by name when the emojiFormat is set to emoji

To reproduce

  1. Set emojiFormat to emoji
  2. Start a conventional commit via the extension
  3. At the emoji step search for a Gitmoji name (e.g. white_check_box)
  4. The Gitmoji for white_check_box is not shown

Expected behavior

The Gitmojis should be searchable by name, the same as when emojiFormat is set to code

Screenshots

Format set to emoji:
image

Format set to code:
image

Application logs

Follow the troubleshooting section and paste the logs here.
@Jak-Ch-ll Jak-Ch-ll added the help wanted Extra attention is needed label Apr 21, 2022
@yi-Xu-0100 yi-Xu-0100 added the bug Something isn't working label Apr 21, 2022
yi-Xu-0100 added a commit that referenced this issue Apr 21, 2022
@yi-Xu-0100
fix: update gitmoji description
0f4fd86 
Update `gitmoji` description to `code` when `emojiFormat` is `emoji`.

close #240
@yi-Xu-0100 yi-Xu-0100 mentioned this issue Apr 21, 2022
Merged
@yi-Xu-0100
Copy link
Collaborator

👋 @Jak-Ch-ll, thanks for your question. Try to download vscode-conventional-commits-c2a792b.vsix in artifacts and test whether the problem is fixed or not. 🚀

@Jak-Ch-ll
Copy link
Author

Hi @yi-Xu-0100,
I tested the version and it indeed works as expected. Thank you for the quick fix! 👍

yi-Xu-0100 added a commit that referenced this issue Apr 22, 2022
@yi-Xu-0100
fix: 🐛 update gitmoji description (#241)
aa24fdd 
Update `gitmoji` description to `code` when `emojiFormat` is `emoji`.

close #240
@github-actions github-actions bot mentioned this issue Apr 22, 2022
Merged
@yi-Xu-0100
Copy link
Collaborator

There is a problem with the automatic release process, this issue is temporarily reserved, and the beta version of the extension can be used for a long time until the new version is released. 😅

@yi-Xu-0100 yi-Xu-0100 reopened this Apr 22, 2022
@yi-Xu-0100 yi-Xu-0100 removed the help wanted Extra attention is needed label Apr 22, 2022
@vivaxy vivaxy added the enhancement New feature or request label May 3, 2022
@vivaxy
Copy link
Owner

vivaxy commented May 3, 2022

v1.24.1 is released

@vivaxy vivaxy closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@vivaxy @yi-Xu-0100 @Jak-Ch-ll