[BUG] Conventional Commits: Cannot read properties of undefined (reading 'fsPath')

[YXL76]

Describe the bug

Excuting extension.conventionalCommits failed.

vscode-conventional-commits/src/lib/conventional-commits.ts

Lines 38 to 48 in 18193e8

	async function getRepository({
	git,
	arg,
	workspaceFolders,
	}: {
	git: VSCodeGit.API;
	arg?: Arg;
	workspaceFolders?: readonly vscode.WorkspaceFolder[];
	}) {
	const _arg = arg?._rootUri.fsPath;
	output.info(`arg: ${_arg}`);

arg is { "w": "git", "x": "Git", "g": 2, "j": "", "q": true, "t": 0 }, no _rootUri in it.

Environment

Version: 1.74.0-insider (system setup)
Commit: 1b1e2a2c5794df1f475976062c754651827634a9
Date: 2022-11-18T05:25:18.342Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: Yes

[unlsycn]

the same problem.

[melMass]

Same issue, tried on both mac and windows.
Running from the command palette works, I disable extensions auto update as it's not the first time I have an extension that stops working mid project. #262 is similar but they only mention the touchbar issue

[yi-Xu-0100]

vscode-conventional-commits/src/lib/conventional-commits.ts

Lines 26 to 28 in 18193e8

	type Arg = {
	_rootUri: vscode.Uri;
	};

The _rootUri is a built-in property of VS Code, and I don't know why it's missing.

Perhaps we can avoid this problem by giving a suitable default value, or by giving the user the option to set this value if they encounter this problem.

[YXL76]

The type should be vscode.Uri | undefined?
Will change const _arg = arg?._rootUri.fsPath; to const _arg = arg?._rootUri?.fsPath; break something? It works fine for me.

[yi-Xu-0100]

@YXL76 Do you mean to change these two contents?

-   _rootUri: vscode.Uri; 
+   _rootUri: vscode.Uri | undefined; 

...

-   const _arg = arg?._rootUri.fsPath;
+   const _arg = arg?._rootUri?.fsPath;

[YXL76]

@YXL76 Do you mean to change these two contents?

-   _rootUri: vscode.Uri; 
+   _rootUri: vscode.Uri | undefined; 

...

-   const _arg = arg?._rootUri.fsPath;
+   const _arg = arg?._rootUri?.fsPath;

yes

[yi-Xu-0100]

@YXL76 Would you be willing to submit a PR to fix this issue and I'll let the action execute to generate a beta version for testing? 😊

[yi-Xu-0100]

Thanks @YXL76 , @melMass @unlsycn Try the beta extension to check it. 😊

• https://github.com/vivaxy/vscode-conventional-commits/actions/runs/3537577440#artifacts

[unlsycn]

Thanks @YXL76 , @melMass @unlsycn Try the beta extension to check it. 😊

• https://github.com/vivaxy/vscode-conventional-commits/actions/runs/3537577440#artifacts

It seems work fine thx

[Alfian5229]

so when its going live?

[yi-Xu-0100]

@Alfian5229 If there is no other problem about it, it will be release on this friday. 😊

[melMass]

Works fine for me too!
waiting for the release 🚀

[yi-Xu-0100]

All subscribers, a new version that fixes this issue has been released~ 😁