-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Conventional Commits: Cannot read properties of undefined (reading 'fsPath') #282
Comments
the same problem. |
Same issue, tried on both mac and windows. |
vscode-conventional-commits/src/lib/conventional-commits.ts Lines 26 to 28 in 18193e8
The Perhaps we can avoid this problem by giving a suitable default value, or by giving the user the option to set this value if they encounter this problem. |
The type should be |
@YXL76 Do you mean to change these two contents? - _rootUri: vscode.Uri;
+ _rootUri: vscode.Uri | undefined;
...
- const _arg = arg?._rootUri.fsPath;
+ const _arg = arg?._rootUri?.fsPath; |
yes |
@YXL76 Would you be willing to submit a PR to fix this issue and I'll let the action execute to generate a beta version for testing? 😊 |
so when its going live? |
@Alfian5229 If there is no other problem about it, it will be release on this friday. 😊 |
Works fine for me too! |
All subscribers, a new version that fixes this issue has been released~ 😁 |
Describe the bug
Excuting
extension.conventionalCommits
failed.vscode-conventional-commits/src/lib/conventional-commits.ts
Lines 38 to 48 in 18193e8
arg
is{ "w": "git", "x": "Git", "g": 2, "j": "", "q": true, "t": 0 }
, no_rootUri
in it.Environment
Version: 1.74.0-insider (system setup)
Commit: 1b1e2a2c5794df1f475976062c754651827634a9
Date: 2022-11-18T05:25:18.342Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: Yes
The text was updated successfully, but these errors were encountered: