Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API and Documentation Overhaul #101

Merged
merged 9 commits into from
Jul 21, 2023
Merged

API and Documentation Overhaul #101

merged 9 commits into from
Jul 21, 2023

Conversation

vivekjoshy
Copy link
Owner

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added test(s) covering the changes (if testable)

Issues Resolved

Fixes #84 #88 #83 #85 #89 #53 #86

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under openskill.py's MIT license.

I certify the above statement is true and correct: @vivekjoshy

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (366af29) 100.00% compared to head (7d145f9) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #101     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        10      -1     
  Lines          622      1764   +1142     
  Branches       149       450    +301     
===========================================
+ Hits           622      1764   +1142     

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vivekjoshy vivekjoshy added this to the v5.0.0 milestone Jul 21, 2023
@vivekjoshy vivekjoshy added this pull request to the merge queue Jul 21, 2023
Merged via the queue into main with commit 3f925f2 Jul 21, 2023
47 checks passed
@vivekjoshy vivekjoshy deleted the api branch July 21, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Documentation
1 participant