Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict ranks and their odds of entire match outcome. #74

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

vivekjoshy
Copy link
Owner

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added test(s) covering the changes (if testable)

Feature

Add the ability to predict ranks and their individual probabilities. It will also give the same rank for two teams if they are likely to draw.

I've also created a benchmark which is able to predict team draws within an entire match:

Confident Matches:  5661
Predictions Made with OpenSkill's PlackettLuce Model:
Correct: 620 | Incorrect: 15
Accuracy: 97.64%
Process Duration: 0.8350820541381836
----------------------------------------
Predictions Made with TrueSkill Model:
Correct: 593 | Incorrect: 42
Accuracy: 93.39%
Process Duration: 3.3510091304779053
Mean Matches: 2.3195027353377617

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under openskill.py's MIT license.

I certify the above statement is true and correct: @daegontaven

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5121ad4) compared to base (4070bee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          573       598   +25     
  Branches       139       145    +6     
=========================================
+ Hits           573       598   +25     
Impacted Files Coverage Δ
openskill/rate.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant