fix issue where numeric values are passed as strings to $in operator #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs to $in operator
vivekratnavel
approved these changes
Dec 26, 2021
vivekratnavel
pushed a commit
that referenced
this pull request
Dec 26, 2021
## [2.16.1](2.16.0...2.16.1) (2021-12-26) ### Bug Fixes * **runstable.js:** fix issue where numeric values are passed as strings to $in operator ([#290](#290)) ([f243462](f243462))
|
🎉 This PR is included in version 2.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug with the advanced filters feature. When the $in operator is used with a numeric field (for example
Id), the values are passed to the server as a string rather than aNumber. This means it is impossible to filter IDs with the $in operator. My changes fix this issue.This pull request uses some existing logic that I found in the codebase:
https://github.com/vivekratnavel/omniboard/blob/master/web/src/components/RunsTable/runsTable.js#L272
It might be useful to move this logic to a new function, but I am not sure where that function should be defined.
Thanks for the very useful project! :)