Change default value of automatic redirects checkbox based on page vi…

…sibility (#2108) Change the Behaviour of the Automatic Redirect to default to false if the corresponding Page is unpublished or archived. Co-authored-by: Markus Fichtner <markus.fichtner@vivid-planet.com>
vivid-planet · May 27, 2024 · fdf9fa7 · fdf9fa7
1 parent 90f3480
commit fdf9fa7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/few-roses-worry.md b/.changeset/few-roses-worry.md
@@ -0,0 +1,5 @@
+---
+"@comet/cms-admin": minor
+---
+
+Automatic Redirects are now set to false if the page is unpublished or archived
diff --git a/packages/admin/cms-admin/src/pages/createEditPageNode.tsx b/packages/admin/cms-admin/src/pages/createEditPageNode.tsx
@@ -66,6 +66,7 @@ export function createEditPageNode({
                 hideInMenu
                 parentId
                 numberOfDescendants
+                visibility
                 document {
                     ... on DocumentInterface {
                         id
@@ -190,6 +191,8 @@ export function createEditPageNode({
             }
         };
 
+        const isActivePage = data?.page?.visibility === "Published";
+
         // Use `p-debounce` instead of `use-debounce`
         // because Final Form expects all validate calls to be resolved.
         // `p-debounce` resolves all calls, `use-debounce` doesn't
@@ -384,7 +387,11 @@ export function createEditPageNode({
                                                                 </>
                                                             }
                                                         >
-                                                            <Field name="createAutomaticRedirectsOnSlugChange" type="checkbox" initialValue={true}>
+                                                            <Field
+                                                                name="createAutomaticRedirectsOnSlugChange"
+                                                                type="checkbox"
+                                                                initialValue={isActivePage}
+                                                            >
                                                                 {(props) => (
                                                                     <FormControlLabel
                                                                         label={