Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download functionality to DAM folders #1230

Merged
merged 18 commits into from
Feb 12, 2024
Merged

Add download functionality to DAM folders #1230

merged 18 commits into from
Feb 12, 2024

Conversation

jomunker
Copy link
Contributor

@jomunker jomunker commented Aug 16, 2023 •
edited

This PR adds the functionality to download folders recursively in the DAM as ZIP.

Video Recordings

Screen.Recording.2023-08-16.at.16.35.13.mov
Screen.Recording.2023-08-16.at.16.37.45.mov

@jomunker jomunker self-assigned this Aug 16, 2023
@jomunker jomunker changed the title Add download functionality to Dam folders WIP: Add download functionality to Dam folders Aug 16, 2023
@jomunker
feat(DamContextMenu): add download link button
6f72a32 
- add generics to RowActionsItem and affected types to support component conversion
@jomunker
refactor(RowActionsItem): use more descriptive name for generic
92348e7
@jomunker jomunker changed the title WIP: Add download functionality to Dam folders Add download functionality to Dam folders Aug 17, 2023
jomunker and others added 2 commits September 11, 2023 19:42
@jomunker @johnnyomair
refactor(cms-api): remove console log from folders.controller.ts
2a57696 
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@jomunker
refactor(cms-api): throw not found error instead of using fallback fo…
38f3aed 
…lder name
@nsams
Copy link
Member

nsams commented Sep 12, 2023

have you tried that with a large number of files and large files? what are the limits this can handle?

@jomunker
Copy link
Contributor Author

have you tried that with a large number of files and large files? what are the limits this can handle?

Don't know actually. Do you know a good way to test this rather than brute force with a lot of files?^^

@nsams
Copy link
Member

nsams commented Sep 22, 2023

what's bad about brute forcing (locally)?

@jomunker
Copy link
Contributor Author

what's bad about brute forcing (locally)?

Nothing. Just a bit annoying to do and not that realistic for production^^ I did it anyways and it has no problems with huge files or a lot of them. It just takes a while. 3GB took like 20 seconds locally

@jomunker
Copy link
Contributor Author

I tried to optimize the time it takes with Promise.all but it made it worse

thomasdax98
thomasdax98 previously approved these changes Oct 27, 2023
View reviewed changes
.gitignore Show resolved Hide resolved
packages/admin/admin/src/rowActions/RowActionsListItem.tsx Outdated Show resolved Hide resolved
johnnyomair
johnnyomair reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge main and resolve conflicts

@vivid-planet vivid-planet deleted a comment from netlify bot Dec 14, 2023
@vivid-planet vivid-planet deleted a comment from netlify bot Dec 14, 2023
johnnyomair
johnnyomair previously approved these changes Feb 8, 2024
View reviewed changes
@johnnyomair
Copy link
Collaborator

@jomunker please fix the pipeline. Thanks!

thomasdax98
thomasdax98 previously approved these changes Feb 8, 2024
View reviewed changes
@thomasdax98 thomasdax98 dismissed stale reviews from johnnyomair and themself via 2494ca9 February 8, 2024 15:39
@thomasdax98
Copy link
Member

thomasdax98 commented Feb 8, 2024 •
edited

@johnnyomair I fixed the pipeline so we can merge this 2494ca9

@johnnyomair johnnyomair changed the title Add download functionality to Dam folders Add download functionality to DAM folders Feb 12, 2024
@johnnyomair johnnyomair merged commit 9d47b5b into main Feb 12, 2024
10 checks passed
@johnnyomair johnnyomair deleted the dam-download-folders branch February 12, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

@thomasdax98 thomasdax98 thomasdax98 left review comments

Assignees

@jomunker jomunker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jomunker @nsams @johnnyomair @thomasdax98