YouTubeVideoBlock: Fix youtubeIdentifier Type
#2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thomasdax98
commented
May 28, 2024
•
thomasdax98
commented
- Fix type of youtubeIdentifier (was required, actually is optional)
- Don't show validation error if youtubeIdentifier is empty
- Allow emptying youtubeIdentifier
johnnyomair
reviewed
May 28, 2024
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
approved these changes
May 28, 2024
johnnyomair
changed the title
youtubeIdentifier TypeyoutubeIdentifier Type
thomasdax98
added a commit
that referenced
this pull request
May 28, 2024
- Fix type of youtubeIdentifier (was required, actually is optional) - Don't show validation error if youtubeIdentifier is empty - Allow emptying youtubeIdentifier --------- Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
added a commit
that referenced
this pull request
May 29, 2024
Backport of #2121 Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.