Implement steps for visual check using image out of file #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3043 +/- ##
============================================
+ Coverage 96.80% 96.81% +0.01%
- Complexity 5859 5879 +20
============================================
Files 823 825 +2
Lines 16622 16679 +57
Branches 1076 1076
============================================
+ Hits 16091 16148 +57
Misses 419 419
Partials 112 112
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
valfirst
requested changes
Aug 10, 2022
|
|
||
| [source,gherkin] | ||
| ---- | ||
| When I $actionType baseline with name `$name` from image out of file `$filePath` |
There was a problem hiding this comment.
syntax is needed to be discussed, for me it looks a bit awkward
| * @param filePath The path to the image file. | ||
| */ | ||
| @When(value = "I $actionType baseline with name `$name` from image out of file `$filePath`", priority = 1) | ||
| public void runVisualTestsUsingImageFile(VisualActionType actionType, String baselineName, String filePath) |
There was a problem hiding this comment.
Suggested change
| public void runVisualTestsUsingImageFile(VisualActionType actionType, String baselineName, String filePath) | |
| public void runVisualTestsUsingImageFile(VisualActionType actionType, String baselineName, Path imageFile) |
There was a problem hiding this comment.
the same for all other steps
Comment on lines
+493
to
+496
| imageTool.when(() -> ImageIO.read(new File(getImageFilePath()))).thenThrow(new IOException()); | ||
| assertThrows(UncheckedIOException.class, | ||
| () -> visualSteps.runVisualTestsUsingImageFile(VisualActionType.COMPARE_AGAINST, BASELINE, | ||
| getImageFilePath())); |
There was a problem hiding this comment.
extract getImageFilePath() to a local variable
|
|
||
| private static String getImageFilePath() | ||
| { | ||
| return ResourceUtils.findResource(FileSystemBaselineStorage.class, "/baselines/baseline.png").getPath(); |
There was a problem hiding this comment.
Suggested change
| return ResourceUtils.findResource(FileSystemBaselineStorage.class, "/baselines/baseline.png").getPath(); | |
| return ResourceUtils.findResource(VisualStepsTests.class, "/baselines/baseline.png").getPath(); |
|
Also, I think it makes to deprecate steps accepting |
ikalinin1
reviewed
Aug 10, 2022
Comment on lines
+13
to
+14
| When I compare_against baseline with name `context` from image out of file `src/main/resources/baselines/context.png` | ||
| When I compare_against baseline with name `context` from image out of file `src/main/resources/baselines/context.png` using storage `filesystem` |
There was a problem hiding this comment.
The steps should work for the absolute path and for the 'resources' (/baselines/context.png))
There was a problem hiding this comment.
I'm ok with absolute path, but I don't agree for 'resources' as it can confuse users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.