-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the default volume script #49
Comments
OK with +/-XdB then. (Is 3 a confortable value?) Thanks for the snippet! I was able to make it even shorter: format () {
perl -ne 'if (/\[(\d+%)\].*?\[(on|off)\]/) {CORE::say $2 eq "off" ? "MUTE" : "$1"; exit}'
} Yes, please go ahead for the patch, I'll give credits to you guys in the commit message before merging. |
Love the shortening! I would however change it from |
I may have assumed incorrectly. I see my output of Can someone confirm that we want to see and modify Capture or if ALSA is messing with me and we only want Playback? |
@Nycroth, only Playback IMO. |
Thanks @xelite! |
@Nycroth I adjusted #51 in scripts/volume but there's an issue, the volume change doesn't work for me. Am I the only one? |
If it works for you, it means that my mixer doesn't have dB information, which might be the case for others. In that case, we should maybe use +/-5%. |
I can only change the volume when using percentage values, as @vivien just suggested. Using dB does not work for me. I'm using PulseAudio, if that matters. |
That may just be a Pulse thing. I'm running pure ALSA and it's working fine for me but I barely notice the difference between the percent and dB. I'm also liking control of 5%. |
Merged, thanks guys! |
I am currently testing the scripts in a default install (Debian stable at the moment), and the script gives me this error:
This is with perl 5.14, could it be that it's just an old version or there's a perl library that's required ? (if it's just the old version then nevermind that, i3blocks package will never be for current debian stable anyway..) |
The problem is your audio card doesn't use "Master" as it's default main control. Many USB cards do this. I've created a patch to prevent this issue in future and more sensibly allow you to change it. Try out patch pull request #53 and see if that's got it for you. |
This is meant to regroup the different issues about the volume: #46, #47, #48 and find a convenient solution, according to #36.
Let's agree on what the default script should look like. So far, I suggest:
+10%
? or+3dB
?)BLOCK_INSTANCE
?ATM, I ended up with this, from all the PR: https://gist.github.com/vivien/0dbbecd0372f808a895c
It would be neat to convert the Ruby snippet to Perl to avoid this dependency, if not to complicated.
Cc: @xelite, @jpleau, @Elfram, @Nycroth
The text was updated successfully, but these errors were encountered: