Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello good sir
While writing a wrapper around gason for my company, I ran into a small problem. Here is a fix proposal.
API breakage here, but original API is erroneous.
The
JsonIterator::operator*
in gason does not implement correctly the pointer semantics. An iterator should be used in those ways (assumingv
is a value containing an object).But in gason is used like this:
This is not consistent with common behaviors of C++ iterators. This patch fixes it.