add theme-techbook-ja #7
Conversation
| @@ -0,0 +1,504 @@ | |||
| @charset "UTF-8"; | |||
There was a problem hiding this comment.
Could you include also SCSS source? When we publish the style file, we can omit SCSS files by specifying oh we don't need them because .npmignore.files is set in package.json
There was a problem hiding this comment.
私もSCSSソースがテーマ・パッケージに含まれるべきだと思います。そのことに関連するissueを書きました：
How to customize the style of themes? #9
- テーマのパッケージにSass (scss)などスタイルシートのソースファイルが含まれている場合（その方法の定義も必要）、ソースファイルがコピーされて、ユーザーはそのscssファイル類を修正してカスタマイズしたうえで本のビルドやプレビューをできるようにする。
| "vivliostyle", | ||
| "vivliostyle-theme" | ||
| ], | ||
| "license": "CC0-1.0", |
There was a problem hiding this comment.
Please note that the license of this file becomes CC0 cc: @akabekobeko
| } | ||
|
|
||
| a[data-ref=sec]::before { | ||
| content: target-counter(attr(href), section) "章"; |
There was a problem hiding this comment.
It seems this theme is designed for Japanese documents so I suppose it's better to rename this theme to such as @vivliostyle/theme-techbook-ja, otherwise it should support multi-language.
html[lang=ja] a[data-ref=sec]::before {
content: target-counter(attr(href), section) "章";
}There was a problem hiding this comment.
Renamed to "theme-techbook-ja".
There was a problem hiding this comment.
I like the idea of supporting multi-language in a single theme than separating them into multiple packages.
The downside of theme with language suffix is that the number of theme packages in npm could be bloated as it continues to support a new language, and it would make search experience worsen.
How about adding html[lang=<lang>] selector to language specific style?
Note: also we have to add this scenario to the design guide.
MurakamiShinyu
force-pushed
the
theme-techbook
branch
from
02b9950
to
8632aa0
Compare
No description provided.